Move access/call family out-of-line into MLIRGenAccessCall.cpp (§1)#226
Merged
Conversation
…w doc 1) 33 property/element-access and call/new methods (property access overloads + logic + base logic, class members/accessor/index/generic- method/base-class access, interface members, extension functions, element access, call expression/builtin/this-method/constructor, iterator next, spread operands, class instantiation family) move from MLIRGenImpl.h into a new MLIRGenAccessCall.cpp TU; header keeps declarations. mlirGenElementAccessTuple<T> and mlirGenCallFunction<T> templates stay inline. 1500 lines out of the header (13402 -> 11902). Extractor: K&R-brace signatures now handled (decl gets ");", def gets ")" plus a normalized brace line). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
§1 TU split — same pattern as #217–#225.
33 property/element-access and call/new methods move from
MLIRGenImpl.hinto a newMLIRGenAccessCall.cppTU: the fivemlirGenPropertyAccessExpressionoverloads plusLogic/BaseLogic,ClassMembersAccess(both overloads), accessor/index/generic-method/base-class access, bothInterfaceMembersoverloads,extensionFunctionLogic,mlirGenElementAccess,mlirGenCallExpression/mlirGenCall/mlirGenCallBuiltInFunction/mlirGenCallThisMethod/mlirGenCallConstructor,callIteratorNext,processOperandSpreadElement,mlirGenArrayReduce, and theNewClassInstance*family. ThemlirGenElementAccessTuple<T>andmlirGenCallFunction<T>templates stay inline.) {on the signature line): declaration gets);, definition gets)plus a normalized brace lineTest plan
🤖 Generated with Claude Code